Tasks
-
Minor
Bug report
#56
Close button of about dialog has no effect
1.0RC1 Resolved and closed
2017-01-10 18:09:56
Anonymous user
@yellow

@yellow
The close button of the about dialog doesn't close the window. The following patch fixes that fo me.
--- a/src/gui/mainwindow.py 2017-01-10 16:18:51.179106257 +0100
+++ b/src/gui/mainwindow.py 2017-01-10 16:42:26.642074365 +0100
@@ -145,7 +145,8 @@
'image', 'logo_head_big.png'), 60, 60, True)
dialog.set_logo(pxbf)
- dialog.show_all()
+ dialog.run()
+ dialog.destroy()
about_button.connect('clicked', show_dialog)
Note that the license button won't be shown, but that's intended behavior if license type is set with set_license_type().
Currently the license button has no effect anyway..
--- a/src/gui/mainwindow.py 2017-01-10 16:18:51.179106257 +0100
+++ b/src/gui/mainwindow.py 2017-01-10 16:42:26.642074365 +0100
@@ -145,7 +145,8 @@
'image', 'logo_head_big.png'), 60, 60, True)
dialog.set_logo(pxbf)
- dialog.show_all()
+ dialog.run()
+ dialog.destroy()
about_button.connect('clicked', show_dialog)
Note that the license button won't be shown, but that's intended behavior if license type is set with set_license_type().
Currently the license button has no effect anyway..
2017-01-12 16:17:10
Hi,
First of all, thanks for the report.
I just tried at home and the about dialog seems to be closed right when I hit the close button.
I'm using Bluemindo trunk (r210), what about you? 1.01RC1 ? Are you using GNOME?
A few lines below in the file there is a dialog.set_license_type(10) statement in order to show the right license (GPLv3), making the previous statement set_license useless.
I'm taking a look at this.
First of all, thanks for the report.
I just tried at home and the about dialog seems to be closed right when I hit the close button.
I'm using Bluemindo trunk (r210), what about you? 1.01RC1 ? Are you using GNOME?
A few lines below in the file there is a dialog.set_license_type(10) statement in order to show the right license (GPLv3), making the previous statement set_license useless.
I'm taking a look at this.
2017-01-12 16:17:42
- Status changed to Working
- Milestone changed to 1.0
- Assign to erwanb
2017-01-12 16:22:11
r211 seems to be a fix for this report.
2017-01-12 16:22:28
- Status changed to Resolved
2017-01-12 16:22:34
- Priority changed to Minor
2017-01-12 18:21:40
Anonymous user
@yellow

@yellow
Thank you, works with r211
Add an attachement
Post to this thread
This bug has been resolved.
This bug report has been closed by a developer.
Being resolved or rejected, this report has been closed by a developer, thus you may not need to add an answer.